search

lelutin / puppet-fail2ban

Manage fail2ban and its jails with puppet
GNU General Public License v3.0
8 stars 31 forks source link

paths-{debian,common}.conf should not be managed anymore #57

Open lelutin opened 2 years ago

lelutin commented 2 years ago

As exposed during analysis for #56 this module manages the file paths-debian.conf on debian systems. The file, as installed by the module, configures default_backend but the file found in upstream fail2ban does not do this. The default backend configuration is already managed within jail.conf so the paths-debian file should not be configuring it too.

but more importantly, both the files paths-common.conf and paths-debian.conf were first managed by the module specifically to keep support for debian jessie (8.x). It was an error to not manage this file within an if block that would apply only to that release of that distro. Since debian jessie is not supported by this module anymore management of both files should be removed.

lelutin commented 2 years ago

it seems as though the files in files/debian/ are currently only remnants of old management and are not deployed by code in manifests. so the fix here would simply be to remove those files and I think it wouldn't even impact anything in deployments.