cronjob problem

[fugit]

Hello thanks so much for the great puppet module.

The class mysql::server::cron::backup cron statement needs double quotes around the command, otherwise the variables aren't replaced. Currenlty they are single quotes.

Thanks again, Keith.

Details:

Index: server/cron/backup.pp

--- server/cron/backup.pp (revision 894) +++ server/cron/backup.pp (revision 895) @@ -14,7 +14,7 @@

 cron { 'mysql_backup_cron':
     ensure => 'present', 

• command => '/usr/bin/mysqldump --default-character-set=utf8 --all-databases --all --flush-logs --lock-tables --single-transaction | gzip > ${real_mysql_backup_dir}/mysqldump.sql.gz && chmod 600 ${real_mysql_backup_dir}/mysqldump.sql.gz',
• command => "/usr/bin/mysqldump --default-character-set=utf8 --all-databases --all --flush-logs --lock-tables --single-transaction | gzip > ${real_mysql_backup_dir}/mysqldump.sql.gz && chmod 600 ${real_mysql_backup_dir}/mysqldump.sql.gz", user => 'root', minute => 0, hour => 1,

[lelutin]

Hi,

Thanks a lot for the feedback! :)

I can't really take the credit for this module. It was originally based on David Schmidtt's work and it's now developed as a joint effort.

You can find, in the repository's description (on the "source" page), the URL to the Redmine on which the common code can be found. So I invite you to check it out: you can also find URLs for other people's modules if you go on the overview page of the "Puppet Modules" project.

Now about the issue: you're totally right, thanks for mentioning it! It would seem someone else fixed that already in their repository (but didn't push it back to the shared module, yet):

http://git.puppet.immerda.ch/?p=module-mysql.git;a=commit;h=3fc679a8227bd06a050739ce7161fca55abcd487

I'll be considering to merge with this repository soon to incorporate a bunch of additions and bug fixes.

In the meantime, I've opened an issue on the redmine to ensure that we merge in the fix above. If you'd like to follow it, here's the URL: https://labs.riseup.net/code/issues/2726

Don't hesitate to contact me again if you find any other bugs!

Thanks again.