search

lelutin / puppet-spamassassin

Install and configure spamassassin either as a service (through spamd) or for use with applications like amavisd. This is a fork of https://bitbucket.org/wyrie/puppet-spamassassin
Other
2 stars 9 forks source link

Spamd log location #21

Closed ghost closed 1 year ago

ghost commented 1 year ago

this allows for the value spamd_log_location to be added in the config, adding the flag -s /path/to/file.log in the spamd service options

lelutin commented 1 year ago

Hi there! This is mostly looking good, many thanks for sending this contribution, that's a great addition!

Since the option gets used as a value to spamd's -s option, it means that it can have a value that's an absolute path, a relative path, or a syslog facility name and there are more options in that case too like adding 2>/dev/null in some cases.

So because of the added possible values, and since the option in the man page is mainly named "syslog facility", I wonder if we'd prefer using a name for the option that's similar to what the spamd option is named. What are your thoughts about this?

For sure though, we should document this module's option as letting users configure either a syslog facility or a log path, and point to spamd's man page for more information (e.g. you can just mention See the details of the -s option in spamd(8p) or something along those lines).

I could add the details to the option's documentation, but I'd rather let you have the chance to do it first if you agree.

Cheers!