search

lelylan / simple-oauth2

A simple Node.js client library for Oauth2
http://lelylan.github.com/simple-oauth2/
1.6k stars 292 forks source link

Feature: exports enums #428

Closed pafik13 closed 1 year ago

pafik13 commented 1 year ago

I recently updated typings and was surprised by the fact that enums don't work unless exported :confused: I propose to export them :wink:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/simple-oauth2/index.d.ts#L12 https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/simple-oauth2/index.d.ts#L17 https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/simple-oauth2/index.d.ts#L22

pafik13 commented 1 year ago

@jonathansamines Could you review my PR? It gets in the way of my tasks at work. If there are reasons why it can't be merged then it's okay and I'll just change the typings.