t-sin
commented
1 year ago This issue is caused by that TODO. I patched to SDL2 the error does not occurs and the Lem frontend window is shown. The window is shown but redrawing has done only when the window is resized, in my environment.
My patch to resolve this issue.
I patched to SDL2 tagged [release-2.0.20](https://github.com/libsdl-org/SDL/releases/tag/release-2.0.20)) like this: ```diff diff --git a/src/render/opengl/SDL_render_gl.c b/src/render/opengl/SDL_render_gl.c index 47d5ae8a1..37b78dc9e 100644 --- a/src/render/opengl/SDL_render_gl.c +++ b/src/render/opengl/SDL_render_gl.c @@ -887,6 +889,7 @@ GL_SetRenderTarget(SDL_Renderer * renderer, SDL_Texture * texture) GL_RenderData *data = (GL_RenderData *) renderer->driverdata; GL_TextureData *texturedata; GLenum status; + GLenum err; GL_ActivateRenderer(renderer); @@ -908,7 +911,16 @@ GL_SetRenderTarget(SDL_Renderer * renderer, SDL_Texture * texture) /* Check FBO status */ status = data->glCheckFramebufferStatusEXT(GL_FRAMEBUFFER_EXT); if (status != GL_FRAMEBUFFER_COMPLETE_EXT) { - return SDL_SetError("glFramebufferTexture2DEXT() failed"); + if ((err = data->glGetError()) != GL_NO_ERROR) { + switch (err) { + case GL_INVALID_ENUM: + return SDL_SetError("glFramebufferTexture2DEXT() failed because of GL_INVALID_EMUM"); + case GL_INVALID_OPERATION: + return SDL_SetError("glFramebufferTexture2DEXT() failed because of GL_INVALID_OPERATION"); + } + + return SDL_SetError("glFramebufferTexture2DEXT() failed with (err, status) = (%d, %d)", err, status); + } } return 0; } ```@cxxxr What do you think about next actions for it? It's a problem of SDL2 so there is no quick workarounds. This needs updating libSDL2 in package manager after PR merged or patching to SDL2 by users, but these ways may weather not be easy or have done with waiting...
cxxxr
Environment
Steps
ros install lem-project/lemlem -f sdl2As is
Black painted SDL2 frontend window appears and it crushes with these logs:
crush logs with `(lem:lem "--debug" "--log-filename" "lem.log")`
```This issue does not occur in my laptop (Intel Graphics driver).
To be
SDL2 window appears rendered with Lem editor screen.
My debugging
I saw this error in that log:
so I think this is caused by SDL2 or graphc driver layer. I found some
glFramebufferTexture2DEXT()related articles like these:but these are not reasons of this issue.
BTW I found codes to raise this error in SDL2 codes:
I think this issue may be caused by illegal pixel format on this environment but I cannot know how different each texture formats between renderer and
(lem-sdl2:create-texture).