allow library config to specify if user/pass is stored in .env or in config itself

lemaiwo / ui5-middleware-route-proxy

UI5Tooling route proxy

MIT License

11 stars 4 forks source link

allow library config to specify if user/pass is stored in .env or in config itself #3

Closed rayatus closed 4 years ago

rayatus commented 4 years ago

in relation with #2

lemaiwo commented 4 years ago

Hi @rayatus, Why using the boolean? Would it not be possible to just check if a username/password is in the UI5 config and if not, go look in the .env file? What do you think?

rayatus commented 4 years ago

I think it's clearer having this boolean on the config part. Don't you think?

lemaiwo commented 4 years ago

Point taken :)