search

lemanhtien / MTSlideToOpen

A simple SlideToUnlock iOS UI component
MIT License
145 stars 51 forks source link

Added Slider text and shadow to image view #9

Closed madan222 closed 5 years ago

madan222 commented 5 years ago

sample1

lemanhtien commented 5 years ago

Thanks @madan222 for the improvement. The slider text is great. However, I don't think it's good to put the shadow inside this lib. I already expose the thumnailImageView outside, so if anyone want the shadow on it, they can change it.

Therefore, it's better not to put the shadow change here. I would love the slider text, can you help to update your merge request to exclude the shadow?

madan222 commented 5 years ago

Thanks @madan222 for the improvement. The slider text is great. However, I don't think it's good to put the shadow inside this lib. I already expose the thumnailImageView outside, so if anyone want the shadow on it, they can change it.

Therefore, it's better not to put the shadow change here. I would love the slider text, can you help to update your merge request to exclude the shadow?

@lemanhtien Make sense, removed the shadow. thanks