search

lemanjo / pyupway

MIT License
1 stars 3 forks source link

Set isOnline flag in MyUplinkService #3

Closed lobstaj closed 4 months ago

lemanjo commented 4 months ago

Hmm.. I tested this and committed some changes to the PR branch. Thought they should show up here? Can you merge them to this if you can see them?

There was still an issue that the IsOnline state was not transferred outside the service. Did quite an ugly fix for that and while I was at it, noticed that we have the same enum x2 but with different numbers. I guess this was due to numbering differences on the units -> Ugly fix on that. Noticed also that the MyUpway Service was still trying to use the old _login method in a few places and fixed those.

lobstaj commented 4 months ago

I don't really know how github should handle this situation when another contributor (of upstream) pushes changes to a PR branch of a fork...

But apparently there are 2 branches now on your own repository, maybe you noticed already (maybe you pushed your changes there?).

I suppose you can create additional PRs from those branches on your own repo (set-isonline-flag-in-myuplinkservice and lobstaj-set-isonline-flag-in-myuplinkservice).

lemanjo commented 4 months ago

Yeah, I merged this and did the additional fixes straight.

I need to lookup at some point how GitHub handled that and what I did wrong, multiple times 😅 I have a strong feeling that I've encountered a use case like that previously, never done it myself though.