Bug in sx127x.py? - Githubissues

lemariva / uPyLoRaWAN

ESP32 using MicroPython meets LoRa and LoRaWAN.

https://lemariva.com/blog/category/lora

Apache License 2.0

225 stars 55 forks source link

Closed frankvanhooft closed 4 years ago

frankvanhooft commented 5 years ago

I'm wondering if there's a bug in the file sx127x.py; I thought I'd ask here before going any further.

The function:

def aquire_lock(self, lock = False): self._lock = False

Shouldn't this be instead:

def aquire_lock(self, lock = False): self._lock = lock

Thanks.

rocket-pig commented 4 years ago

Please fork or PR and make your revisions public! I for one would greatly appreciate that.

( Im not connected to original author. These boards are in the mail and I'm looking forward to working on them. )

lemariva commented 4 years ago

I've some time today and I cleaned the code.