search

lemaslab / lemaslab.github.io

The LemasLab website at the University of Florida
https://lemaslab.github.io/
1 stars 40 forks source link

Portrait Issues #44

Open XinsongDu opened 4 years ago

XinsongDu commented 4 years ago

Four people in "People" page (https://lemaslab.github.io/people/) do not have their avatar, please work on asking them for their photos and put the photos on our website.

thulium1 commented 4 years ago

I have email Andrew, Emily, and Sakina. However, Joshua do not have any contact or any information on the people page, therefore, I don't know how to contact him.

XinsongDu commented 3 years ago

@sheilarodcast Please crop your portrait to 1:1.168 (width:height) and make a pull request. Detailed steps would be:

  1. Merge master branch to sheila branch.
  2. Make changes to the portrait.
  3. Make pull request from sheila branch to master branch.
sheilarodcast commented 3 years ago

Hi,

I just pulled the request, but not sure if it worked well. Could you let me know?

Thank you, Sheila

From: Xinsong Du @.> Sent: Sunday, June 6, 2021 6:21 PM To: lemaslab/lemaslab.github.io @.> Cc: Rodriguez,Sheila @.>; Mention @.> Subject: Re: [lemaslab/lemaslab.github.io] Portrait Issues (#44)

[External Email]

@sheilarodcasthttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_sheilarodcast&d=DwMCaQ&c=sJ6xIWYx-zLMB3EPkvcnVg&r=Gx1jw-FxUgFlRfjxQ9HPZBRqqOoB97FImugKHJDe5Pk&m=KRQ1w3RxOw5Qb0n3AQdMpp0ASuF8QViZTw55P09JuzU&s=kbBhxhkQUTIR0JB2PLhNWm7hYR-msOD0mtHyzrWZMFc&e= Please crop your portrait to 1:1.168 (width:height) and make a pull request. Detailed steps would be:

  1. Merge master branch to sheila branch.
  2. Make changes to the portrait.
  3. Make pull request from sheila branch to master branch.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_lemaslab_lemaslab.github.io_issues_44-23issuecomment-2D855472110&d=DwMCaQ&c=sJ6xIWYx-zLMB3EPkvcnVg&r=Gx1jw-FxUgFlRfjxQ9HPZBRqqOoB97FImugKHJDe5Pk&m=KRQ1w3RxOw5Qb0n3AQdMpp0ASuF8QViZTw55P09JuzU&s=_M7tdMZYiaYSHkobdGDiwI9vAApTrXHFCt8RpM8jsA4&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ASW7PSQ3GZCUBRSGPVDOYTDTRPYIPANCNFSM4NIS63UQ&d=DwMCaQ&c=sJ6xIWYx-zLMB3EPkvcnVg&r=Gx1jw-FxUgFlRfjxQ9HPZBRqqOoB97FImugKHJDe5Pk&m=KRQ1w3RxOw5Qb0n3AQdMpp0ASuF8QViZTw55P09JuzU&s=PuJ8KcTV4YmuEeN7UkjgUfTUTYR4kzPDobJMkNRR5F8&e=.

XinsongDu commented 3 years ago

@sheilarodcast your pull request was not appeared on this repo. Where did you make the change? Steps of making changes to the website would be:

  1. merge master branch to your own branch sheila (i.e., make a pull request from master to sheila)
  2. make changes you want (in this situation, it is cropping the portrait to 1:1.618)
  3. make a pull request to the master branch (i.e., make a pull request from sheila to master). The pull request is a button on the GitHub repo page: Screen Shot 2021-06-08 at 2 33 00 PM
sheilarodcast commented 3 years ago

On my side, my branch appears as sheilarodcast.

From: Xinsong Du @.> Sent: Tuesday, June 8, 2021 2:33 PM To: lemaslab/lemaslab.github.io @.> Cc: Rodriguez,Sheila @.>; Mention @.> Subject: Re: [lemaslab/lemaslab.github.io] Portrait Issues (#44)

[External Email]

@sheilarodcasthttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_sheilarodcast&d=DwMCaQ&c=sJ6xIWYx-zLMB3EPkvcnVg&r=Gx1jw-FxUgFlRfjxQ9HPZBRqqOoB97FImugKHJDe5Pk&m=NL1FdkpfGBI7-siD8SeDIHn5bU8CgR3sanIROw480vQ&s=_TY5kDEosKiLNSUkB8cFPy0yXzyOZBIp8jER0Bas42M&e= your pull request was not appeared on this repo. Where did you make the change? Steps of making changes to the website would be:

  1. merge master branch to your own branch sheila (i.e., make a pull request from master to sheila)
  2. make changes you want (in this situation, it is cropping the portrait to 1:1.618)
  3. make a pull request to the master branch (i.e., make a pull request from sheila to master). The pull request is a button on the GitHub repo page:

[Screen Shot 2021-06-08 at 2 33 00 PM]https://urldefense.proofpoint.com/v2/url?u=https-3A__user-2Dimages.githubusercontent.com_16085076_121238775-2D76c87480-2Dc866-2D11eb-2D8d9e-2Df3b5f7094b90.png&d=DwMCaQ&c=sJ6xIWYx-zLMB3EPkvcnVg&r=Gx1jw-FxUgFlRfjxQ9HPZBRqqOoB97FImugKHJDe5Pk&m=NL1FdkpfGBI7-siD8SeDIHn5bU8CgR3sanIROw480vQ&s=m4_s1dzupXHLt-lCEE1qwa7V6QQ4GjkLZGzfFLnSBFo&e=

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_lemaslab_lemaslab.github.io_issues_44-23issuecomment-2D857000575&d=DwMCaQ&c=sJ6xIWYx-zLMB3EPkvcnVg&r=Gx1jw-FxUgFlRfjxQ9HPZBRqqOoB97FImugKHJDe5Pk&m=NL1FdkpfGBI7-siD8SeDIHn5bU8CgR3sanIROw480vQ&s=Twd4c4GZP89szHBwK9xYTAwsiZcMzLD2gOaLZ4gxLn0&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ASW7PSVJIP7XN4HS2ZLP3WDTRZPAJANCNFSM4NIS63UQ&d=DwMCaQ&c=sJ6xIWYx-zLMB3EPkvcnVg&r=Gx1jw-FxUgFlRfjxQ9HPZBRqqOoB97FImugKHJDe5Pk&m=NL1FdkpfGBI7-siD8SeDIHn5bU8CgR3sanIROw480vQ&s=mJBQQb8hNBNP3YROuqXbI_HqwGAz81rAoCp_TLHtbbw&e=.

XinsongDu commented 3 years ago

Oh, I see where you made the change (https://github.com/sheilarodcast/lemaslab.github.io/blob/master/images/people/Sheila_Rodriguez.jpeg). The modification is great.

Since there is already a branch for you in this repo (https://github.com/lemaslab/lemaslab.github.io/tree/sheila), you need to work using this link under lemaslab repo instead of a forked repo. Working on a forked repo will not make any change to the website.