lemberg / connfa-ios

Open Source iOS app for Conferences and Events
http://connfa.com
47 stars 40 forks source link

Share my schedule function is not working on some devices #13

Open alikuru opened 7 years ago

alikuru commented 7 years ago

Share my schedule button is not functioning correctly on devices with bigger screens, i.e. 6 plus.

Since the button is also missing the share code, and DCProgramViewController.m line 407 seems to be disabling the button in case of a missing code, I'm guessing that somehow code generation is hindered in these devices.

Share my schedule not working

alikuru commented 7 years ago

One of our users reported that he is having the same issue on a standard, non-plus iPhone 7, running iOS 11. Apparently I am wrong on my assumption that the issue only affects "plus" size devices.

alikuru commented 7 years ago

Since I have seen this issue on an iPhone 5 running on 10.3.3, I can confirm that it is not related to device model, screen size or the iOS version.

Changing the title.

oleh-kurnenkov commented 7 years ago

Hi @alikuru. This is the possible behavior of the app. Creating or updating the schedule happens in two points. First is when you're opening "My Schedule" page DCProgramViewController.m line#601. Second is when you're trying to add event to your schedule DCEventDetailViewController.m line#551. That's why there is a possibility that you won't have schedule created when you don't have the internet connection.

alikuru commented 7 years ago

I see.

Is there any way to change this behavior? What I understand from our users' experience is if app somehow misses the schedule code generation in its initial attempt, it doesn't try to create it again in later usage. So users with no code at the start left with no code at all for all their time on the app, which kills their changes for sharing their schedule.

oleh-kurnenkov commented 6 years ago

@alikuru If the schedule is not created, the application tries to create it each time when a user enters "My schedule" screen or tries to add a new event to his schedule. In addition, you can use an updateSchedule method manually.