search

lemeryfertitta / Climbdex

Search engine for training board climbs
https://climbdex.com
MIT License
42 stars 10 forks source link

Beta page - better iframe sizing #27

Open lemeryfertitta opened 6 months ago

lemeryfertitta commented 6 months ago

Some widths and heights of the embedded instagram videos are a bit awkward to view, either on desktop, mobile, or both. Its possible that getting the post metadata could allow for better sizing, though my initial look into this wasn't very fruitful.

gardaholm commented 6 months ago

The Left / Right icons are a bit off compared to the result page, at least on my screens (mobile + desktop). Maybe this can be adressed too in with this issue.

lemeryfertitta commented 6 months ago

Good catch, I fixed those though its probably not worth a deploy, will just catch it in the next deploy.

The iframe sizing is a little trickier. I'm not even sure its possible to make it consistent since instagram has a whole bunch of different sizes that it gives you. The apps don't even bother with embedding and just send you to instagram, but I like the idea of embedding, I feel like it makes it a bit smoother to navigate.

gardaholm commented 6 months ago

I think it's ok as it is, it differs depending on the video sizes and if it was posted as video only or video in a slideshow.

Overall its still easy to use and better to scroll throw the beta videos than using the app.