search

lemeryfertitta / Climbdex

Search engine for training board climbs
https://climbdex.com
MIT License
42 stars 10 forks source link

Range Slider + Classics #52

Closed gardaholm closed 5 months ago

gardaholm commented 6 months ago

Adressed Issues #40 and first part for #39 Range filter is working, tested it a lot and made it dynamic, based on the difficulty_grades from da sqlite.

Pretty sure that the Javascript at the bottom can be optimized a bit. But I'm already pretty happy with the result. Would be great if you could have a look and test it – thanks! Did some testing and compared results with the app.

Classics are being filtered, but didn't start with displaying the icon on results.

gardaholm commented 6 months ago

Added Classic Icons for Issue #39 used the © as you've mentioned, not the (b). Updated the Advanced Filter to only be shown for Decoy + Tension Boards, I think these are the only two boards which support classics?

lemeryfertitta commented 6 months ago

Added Classic Icons for Issue #39 used the © as you've mentioned, not the (b). Updated the Advanced Filter to only be shown for Decoy + Tension Boards, I think these are the only two boards which support classics?

Nice! I'll double check on the classics. I also think it may just be worth showing the "hidden" Kilter classics for a consistent UI.

I'm away on a trip at the moment but I'll do a closer code review on this and try to get these features merged and deployed in the next couple weeks when I'm back.

gardaholm commented 5 months ago

@gardaholm Sorry about dropping the ball on this one. Went on a trip and then had a bit less motivation to work on Climbdex after my return. I have access to the TB2 now and it has renewed my psych a bit 😄 .

same here :) and yes the TB2 is ace! So good that I almost destroyed my tendons a few weeks ago :(

Will fix the issues and remove my german comments (forgot to remove them firsthand …)