search

lemire / FastPFor

The FastPFOR C++ library: Fast integer compression
Apache License 2.0
873 stars 123 forks source link

Fixes issue 99. Replace aligned loads with unaligned. #101

Closed lemire closed 1 year ago

lemire commented 1 year ago

Based on https://github.com/lemire/FastPFor/pull/100 but arguably more complete and better?

Credit to @pps83 for the hard work.

Fixes https://github.com/lemire/FastPFor/issues/99

lemire commented 1 year ago

@pps83 Would you review?

pps83 commented 1 year ago

also, it looks it's based off from some old version, not from the last master.

pps83 commented 1 year ago

I checked the PR, many of the issues I saw got resolved. However, I still see one place where a byte or two end up unmodified the output. Perhaps, it's ok to merge this one, and take a look at that issue separately.

lemire commented 1 year ago

Merging.

@cbsmith : I invite you to prepare a distinct PR if you'd like.