lemire / FastPFor

The FastPFOR C++ library: Fast integer compression
Apache License 2.0
883 stars 124 forks source link

Avoid linker errors when including simple8b_rle.h/simple9_rle.h/vsencoding.h headers from multiple files #89

Closed pps83 closed 1 year ago

lemire commented 1 year ago

It seems that you are assuming C++17? See failed CI tests.

pps83 commented 1 year ago

Yes, I see. I use c++20 in my code, so, it was ok on my side. The only way to make it work is to add .cpp files. Are you ok with that?

pps83 commented 1 year ago

I think I have a better idea to fix it.

pps83 commented 1 year ago

@lemire please recheck the PR

lemire commented 1 year ago

This should be fine. Thanks. Merging.