library fixes: move functions out of headers or make them inline

lemire / SIMDCompressionAndIntersection

A C++ library to compress and intersect sorted lists of integers using SIMD instructions

Apache License 2.0

422 stars 59 forks source link

library fixes: move functions out of headers or make them inline #27

Closed yonik closed 3 years ago

yonik commented 3 years ago

This PR fixes linking issues with clients/users of the SIMDCompressionAndIntersection library . When including "codecfactory.h" in more than one client object file, multiple linking errors would result due to non-inline functions and data located in header files. I moved larger functions to .cpp files, and specified "inline" for smaller functions. I spot-checked the resulting performance and didn't notice any differences.

lemire commented 3 years ago

Looks good to me. Merging.