search

lemire / despacer

C library to remove white space from strings as fast as possible
BSD 3-Clause "New" or "Revised" License
151 stars 14 forks source link

Enable optimizations in cmakelists #17

Closed sharpobject closed 10 months ago

lemire commented 10 months ago

If you build a CMake project using visual studio, you can build both the release and debug version, like any other visual studio project. And like any such project, the default is Debug. This PR would break this behaviour.

It is worse than that: the call to -march=native is somewhat bad and really should be avoided, but this requires a switch to runtime dispatching... which requires non trivial engineering to be done portably.

lemire commented 10 months ago

I am going to close this. The concern is legitimate, but it was better to update the README.

Forcing the flags would just break CMake. It would be considered bad practice.