search

lemire / simdcomp

A simple C library for compressing lists of integers using binary packing
BSD 3-Clause "New" or "Revised" License
488 stars 53 forks source link

Port for compatibility with Visual Studio 2013 #3

Closed weltling closed 9 years ago

weltling commented 9 years ago

Only some minor changes was needed, now it is usable with VS2013.

Thanks.

lemire commented 9 years ago

Looks good.

lemire commented 9 years ago

I have included you as one of the collaborators of this project.

weltling commented 9 years ago

@lemire thanks for checking this. I'm putting most of my efforts into the PHP project, however the technology you use is pretty much exciting. Especially as there's no inline ASM. Despite of the learning fun, I'm also looking for the ways to improve PHP, so I landed here :)

The current PHP aims SSE2 as default, but also still C89. On windows, that's also about supporting an older compiler like VS2012. What do you think about making simdcomp C89 compatible?

Cheers.

lemire commented 9 years ago

C89 compatibility is a fine goal and maybe not difficult to achieve here. One probably wants to have fallback defines for uint32_t. It just gets a bit uglier, but with good testing, it should be no problem.

weltling commented 9 years ago

Great, I'll be doing that. Will put a PR once it's done.

Thanks.

lemire commented 9 years ago

Excellent.