lemma-osu / gee-knn-python

0 stars 0 forks source link

Merge `fb-add-methods` branch into `main` #5

Closed grovduck closed 11 months ago

grovduck commented 11 months ago

With the recent change in #4 to delegate all fitting/training to sknnr estimators rather than separate implementations in this package, the core five estimators (RawKNNClassifier, EuclideanKNNClassifier, MahalanobisKNNClassifier, MSNClassifier, and GNNClassifier) and now passing initial tests when running training locally and running predict using GEE. We'd like to get back to the main branch so that we have a single Github URL to pass along to collaborators to use before we publish this package to PyPI.

We'll do a merge commit to retain all the gory history from early iterations. @aazuspan, do you have any concerns before I go forward with the merge?

aazuspan commented 11 months ago

Nope, LGTM!