lemma-osu / sknnr

scikit-learn compatible estimators for various kNN imputation methods
https://sknnr.readthedocs.io
0 stars 1 forks source link

Only store array-like `dataframe_index_in_` and fix `CCA` compability with `list` #56

Closed aazuspan closed 1 year ago

aazuspan commented 1 year ago

This resolves #55 by only storing the dataframe_index_in_ if it's array-like, and updates test_estimators_support_dataframe_indexes to confirm that the list.index method isn't accidentally stored like it previously was.

While testing this I noticed a small bug that prevented fitting CCATransformer with a y: list due to the dimensionality check. Just changing the order of casting and checking shape solved that, so I included it here as a quick fix.