search

lemnos / tt

A terminal based typing test.
MIT License
714 stars 48 forks source link

prevent duplicate words #22

Closed gaoDean closed 1 year ago

gaoDean commented 2 years ago

self-explanatory; lol i dont know anything about golang, if u find anything like bad practices pls tell me; I am also bad at github and I don't know how to separate commits into branches, so I just committed the last pull request with this one, pls tell me how to do properly

gaoDean commented 2 years ago

alright, this should be good to go? Have removed the lastfield function and implemented your way of storing last word @rvaiya

lemnos commented 1 year ago

Sorry for the abysmal response time. This looks good and has been merged in (5a179f25). I squashed the commits into a single commit (you should do this when submitting PRs, since it keeps the history nice and clean). One minor quibble is that 'new' is a reserved keyword in go. While the code compiles, it is probably better to avoid this, so I renamed the variable in 65af3c34.

gaoDean commented 1 year ago

Oh nice, i totally forgot about this.