search

lemon24 / reader

A Python feed reader library.
https://reader.readthedocs.io
BSD 3-Clause "New" or "Revised" License
438 stars 36 forks source link

EntryCounts.unread/unimportant #283

Open lemon24 opened 2 years ago

lemon24 commented 2 years ago

https://github.com/lemon24/reader/blob/7c4df8af5cfe9b5282e46c019950366893854c75/src/reader/_app/__init__.py#L402-L408

Also useful here: https://github.com/dbrennand/Feederbot/issues/16

lemon24 commented 5 months ago

Some 2024 notes:

  1. Now that Entry.important is tri-state (bool or None), .unimportant cannot be a total - important property anymore, it needs to come from the database; "unimportant" means important == False, because that's what mark_entry_as_unimportant() defines it as.
  2. The same fields/properties should be added to EntrySearchCounts.
  3. The avg{1m,3m,1y} properties can be ignored for now, following the work in https://github.com/lemon24/reader/issues/254#issuecomment-1807064610 / this gist / https://github.com/lemon24/reader/issues/306#issuecomment-1694655504 I am relatively convinced the averages API is not powerful enough, and should be deprecated in 4.0.
lemon24 commented 2 months ago

Remaining work: add unread property (I mistitled https://github.com/lemon24/reader/commit/c8678236ec515820458df4cad8790adcf628944b).

JCart97 commented 1 month ago

Remaining work: add unread property (I mistitled c867823).

Looking at this issue - by the latest comment, do you mean adding unread to the src/reader/types.py file?

lemon24 commented 1 month ago

Looking at this issue - by the latest comment, do you mean adding unread to the src/reader/types.py file?

Yup.