search

lemon24 / reader

A Python feed reader library.
https://reader.readthedocs.io
BSD 3-Clause "New" or "Revised" License
438 stars 36 forks source link

Allow reusing a Reader object after close()/__exit__() #284

Closed lemon24 closed 2 years ago

lemon24 commented 2 years ago

Because why not, especially when using as a context manager?

It doesn't really go against the main requirement in https://github.com/lemon24/reader/issues/206#issuecomment-1173147462:

it should not be possible to (unknowingly) leak connections by using the same Reader object from multiple threads

For comparison, SQLAlchemy allows "reviving" an Engine as well.

lemon24 commented 2 years ago

Resolved in #206 / https://github.com/lemon24/reader/commit/05c1260891b058cd5e3e15cc15ce5ca8fdd220d7.