search

lemon24 / reader

A Python feed reader library.
https://reader.readthedocs.io
BSD 3-Clause "New" or "Revised" License
456 stars 38 forks source link

Enhancement #317 mark-as-read-backfill #333

Closed Sakunam closed 6 months ago

Sakunam commented 7 months ago

https://github.com/lemon24/reader/issues/317

I did the first way you suggested.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 97.77778% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.90%. Comparing base (25a7207) to head (8701067).

Files Patch % Lines
src/reader/plugins/mark_as_read.py 92.85% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #333 +/- ## ========================================== - Coverage 95.16% 91.90% -3.26% ========================================== Files 95 95 Lines 11611 11656 +45 Branches 2179 1539 -640 ========================================== - Hits 11050 10713 -337 - Misses 478 875 +397 + Partials 83 68 -15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Sakunam commented 6 months ago

I think something's wrong with /src/reader/_storage/_sqlite_units.py, I ran the type checking with mypy for my commits and the main branch and I get the same three errors.

lemon24 commented 6 months ago

Hi, I'm currently away from a computer. I'll be able to take a closer look at this starting with Wednesday.

Re: typing failures: This is likely caused by a new version of mypy being released, feel free to ignore it (IIRC plugins are excluded from type checking).

lemon24 commented 6 months ago

Re: typing failures: This is likely caused by a new version of mypy being released, feel free to ignore it (IIRC plugins are excluded from type checking).

mypy issue fixed in https://github.com/lemon24/reader/commit/ccf010c598dc02cf8a493abbd27bd6babddde464, rebasing on top of latest should fix it here too.

Sakunam commented 6 months ago

Sorry I took so long, I was on international travel and it took me some time to figure out the changes. Let me know if there's anything wrong. I'm not entirely sure what's going on with the make.bat

lemon24 commented 6 months ago

Sorry I took so long, I was on international travel and it took me some time to figure out the changes. Let me know if there's anything wrong. I'm not entirely sure what's going on with the make.bat

No worries, thank you for looking into it. Will be back soon with another commit fix the coverage and the make.bat issue.

Sakunam commented 6 months ago

Sounds good, thanks for everything!