search

lemonad / moodle-mod_videofile

Easy cross-browser compatible videos for Moodle 2.5+ via Video.js.
Other
10 stars 17 forks source link

Updating VideoJS code #15

Closed gdkraus closed 10 years ago

gdkraus commented 10 years ago

We've been doing work on the accessibility of the Video JS player, and we are also interested in incorporating it into Moodle. I have two questions about your plugin.

  1. Is it necessary to use the video.dev.js file in deployment instead of relying solely on video.js?
  2. If it is necessary, what steps are you taking to create video.dev.js so if we want to update the VideoJS source code we can?

Thanks.

lemonad commented 10 years ago

It's not at all necessary to use video.dev.js, I include it for debugging purposes only. I did use it in an earlier release (0.30) though, perhaps you're looking at an older revision of the source code?

I build video.js according to the build instructions, i.e. using grunt. I really should include that information in that repository, I keep forgetting how it's built myself : )

Hope that helps and let me know if there's anything else I can do to help!

lemonad commented 10 years ago

Oh, are you also asking if I could update this plugin with the latest code from video.js? It's definitely time to make another release anyhow.

gdkraus commented 10 years ago

We have some more changes we are submitting back to core shortly, so we'd prefer that version, but if it's as simple as dropping in the new .js file we can handle that.

lemonad commented 10 years ago

Just let me know when you want me to pull in the changes and I'll make a new release and upload it to Moodle. I'll close this issue now but feel free to open a new one whenever your changes goes into core.