search

lemonde / angular-ckeditor

CKEditor directive for Angular.
137 stars 133 forks source link

Source Mode Editing bug fixed #33

Open aigoncharov opened 8 years ago

aigoncharov commented 8 years ago

If a user made some changes in the source mode the model will update only upon clicking the source mode button

Yvem commented 8 years ago

Hello and thanks !

can you elaborate a little bit on what the problem is and how can I reproduce it ?

And / or could you add tests ?

l0c0luke commented 8 years ago

i see this as well but i thought it was a wysiwyg problem?

if you modify the content of the wysiwyg while viewing the source ... the underlying model doesnt change... you have to click the source button again, to go back to visual mode, then the model gets updated

human33 commented 8 years ago

i see this as well but i thought it was a wysiwyg problem?

if you modify the content of the wysiwyg while viewing the source ... the underlying model doesnt change... you have to click the source button again, to go back to visual mode, then the model gets updated

It because model updates on events require change focus. If you click somewhere else model updates too.

human33 commented 8 years ago

Hello and thanks !

can you elaborate a little bit on what the problem is and how can I reproduce it ?

  1. show model used for editor somewhere else
  2. edit text
  3. model not changed until you click somewhere for change focus
Orlicek commented 8 years ago

+1

JBustin commented 8 years ago

@l0c0luke @human-- I couldn't reproduce. Do you have still the problem ? A plunker to illustrate ?

FreeFly19 commented 7 years ago

Have the same issue, please accept the commit...

aigoncharov commented 7 years ago

@JBustin Here's a plunkr that demonstrates the issue https://plnkr.co/edit/ZTNJXJA7GsTKlBMjRPio?p=preview

Try typing something in, an alert with updated model is going to show up only after you click 'Source' again