Pass CKEditor instance on ready callback

lemonde / angular-ckeditor

CKEditor directive for Angular.

137 stars 133 forks source link

Pass CKEditor instance on ready callback #46

Open MicahFulton opened 8 years ago

MicahFulton commented 8 years ago

This solves issue https://github.com/lemonde/angular-ckeditor/issues/37

Adds the ability to get the reference to the editor instance on ready().
Updates the angular model on the selection change and paste events.

mckoon commented 8 years ago

The ability to get the CKEditor instance in the provided ready callback seems like a good change. I would like to use this instead of my separate directive to get the instance.

Is this something that is likely to be merged?

Thanks!

JBustin commented 7 years ago

@mckoon We prepare a release with many fixes. Could you remove the minification of this PR ? Thx

mckoon commented 7 years ago

@JBustin - I think you mentioned me by mistake; this PR is from @MicahFulton not me.

Thanks

coolduebtn commented 7 years ago

when will the changes be merged on the master. I am waiting for this fix eagerly.

JBustin commented 7 years ago

@MicahFulton We prepare a release with many fixes. Could you remove the minification of this PR ? Thx

coolduebtn commented 7 years ago

@JBustin Can you please merge the changes on master asap. I need this change urgently or else I will have to create a separate directive just with this change..