search

lemonmade / bigfoot

A jQuery plugin for creating exceptional footnotes.
http://www.bigfootjs.com
MIT License
936 stars 69 forks source link

appendPopoversTo not working #45

Open diego06884 opened 9 years ago

diego06884 commented 9 years ago

I'm trying to append popovers to a different element in the DOM following the documentation but this property seems to be broken.

lemonmade commented 9 years ago

Can you provide a small chunk of code that demonstrates this issue?

rougeux commented 6 years ago

I have this same issue. Using the same sample code from the demo and setting appendPopoversTo to body, they are still appended to the closest block element (in this case, a p).

Here is code demonstrating the issue. Inspect where the footnote is being placed.

<html>
<head>
    <link href="https://cdnjs.cloudflare.com/ajax/libs/bigfoot/2.1.4/bigfoot-number.min.css" media="all" rel="stylesheet" type="text/css" />
    <script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js"></script>
    <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/bigfoot/2.1.4/bigfoot.js"></script>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
    <title>Bigfoot.js append issue</title>
</head>
<body>

<p>
    <sup id="fnref:1">
        <a href="#fn:1" rel="footnote">1</a>
    </sup>
</p>

<div class="footnotes"><ol>
    <li class="footnote" id="fn:1">
        <p>footnote.<a href="#fnref:1" title="return to article"> ↩</a><p>
    </li>
</ol></div>

<script type="text/javascript">
    $.bigfoot({appendPopoversTo: "body"});
</script>

</body>
</html>
75th commented 6 years ago

It appears this feature was never implemented, or was deleted at some point. I'm looking in the Coffeescript file; there is no instance of the string appendPopoversTo in there, and from what I can tell, there's no logic in createPopover to put the popover anywhere other than the default.