search

lemonsaurus / django-simple-bulma

Django application to add the Bulma CSS framework and its extensions
MIT License
136 stars 16 forks source link

Submodule Bulma repo instead of cloning #52

Closed JonasUJ closed 4 years ago

JonasUJ commented 4 years ago

Adds Bulma as a submodule, meaning manual updates wont be necessary any more. This almost closes #42. Now it is just missing the extensions.

lemonsaurus commented 4 years ago

Thanks for doing this!

I don't think I want to merge this into master until we've solved bulma extensions submoduling and PyPI builds, but maybe we can merge it into a feature branch and continue work there.

lemonsaurus commented 4 years ago

Created a new feature branch for this now. Can you target submodule_refactor instead of master?

JonasUJ commented 4 years ago

Done :)

JonasUJ commented 4 years ago

If we want the extensions to be submodules too, we probable have to do it like these people have https://github.com/Wikiki/bulma-extensions. It shouldn't be too much trouble, since all the extensions (afaik) have this structure "/src/sass/" and that would just have to be isolated.

About the PyPi builds, running python setup.py sdist bdist_wheel only includes the "/bulma/sass/" directory in the "build/" because I added these two lines to the MANIFEST.in

prune django_simple_bulma/bulma
graft django_simple_bulma/bulma/sass
lemonsaurus commented 4 years ago

Excellent, that's very exciting. Then this may be closer to releasable than I thought.