search

lemonsaurus / django-simple-bulma

Django application to add the Bulma CSS framework and its extensions
MIT License
136 stars 16 forks source link

Add extension submodules #55

Closed JonasUJ closed 4 years ago

JonasUJ commented 4 years ago

Further work on #42 Closes #7

I didn't include some extensions because they were extremely out of date or simple not worth the time. Most of the extensions are made by the same guy, so their directory structure all match up, but others have wildly differing setups. I tried my best to have it figure out what files are relevant, meaning adding new extensions should only be a matter of running:

git submodule add <repo-link>
git mv ./[extension_name]/ ./django_simple_bulma/extensions/[extension_name]

Since i removed the old extensions, this is definitely not backwards compatible, because of this I suggest that when this branch is merged we release it as v2 or at least v1.4. Also, the way I've been testing is with one big file with all the extensions, which is only a visual verification. I also haven't tested the custom variables some of the extensions use.

JonasUJ commented 4 years ago

Wouldn't you also have to change the MANIFEST.in file? I'm wondering if maybe we should document how to add these additional submodules in the wiki or something.

That depends on the extension. Out of 19 extensions I only needed a special case for two in the MANIFEST.in.

Which ones?

Some where duplicates (like steps and tags-input), another is the iconpicker that doesn't even work on the website. The dashboard and blocklist ones are also excluded, I think i had some trouble making them work. The spacing extension became obsolete in Bulma v0.9.0.

JonasUJ commented 4 years ago

The readme currently says we use Bulma-Extensions v4.0.0, but I'm unsure of where this number comes from, considering each extension has its own version control.

lemonsaurus commented 4 years ago

it may have been the npm package number at the time.

image

Seems that's at 6.2.4 now.

Would be better to just include a list of which specific extensions we do support, though. That's probably the final thing I'd like to see in this PR before merging. And obviously version isn't really erlevant anymore now with the submodules. It'll be whatever was the latest version when the last release happened. We can do releases now and then to bump these versions.

JonasUJ commented 4 years ago

I remember now that the iconpicker extension doesn't work because it uses a fontawesome cdn for version 4 that now responds with 404, probably because it is no longer supported.

lemonsaurus commented 4 years ago

excellent!