search

lemonsaurus / django-simple-bulma

Django application to add the Bulma CSS framework and its extensions
MIT License
136 stars 16 forks source link

Missing files in v2.0.0 release files #61

Closed bpepple closed 4 years ago

bpepple commented 4 years ago

Updating to v2.0.0, and it looks like the submodules you're using now aren't included in the tarball. Since I get the following error when attempting to run django.

FileNotFoundError: [Errno 2] No such file or directory: '/home/bpepple/.local/share/virtualenvs/metron-UZX73b7p/lib/python3.6/site-packages/django_simple_bulma/bulma/sass'

Pulled the tarball down from the release page, and verified the bulma folder is empty.

lemonsaurus commented 4 years ago

Looks like you're right, sorry for any inconvenience caused.

I don't have time to look into this today but I'll try to get it sorted out ASAP. If you or anyone else reading this has any ideas or would like to open a PR with a fix, that'd be much appreciated.

lemonsaurus commented 4 years ago

@bpepple I believe this should be resolved now.

The problem was that we were not checking out the submodules in the GitHub Actions workflow that was responsible for building the source distribution.

Could you verify that everything works as expected in release 2.0.2, when you get a chance?

bpepple commented 4 years ago

Could you verify that everything works as expected in release 2.0.2, when you get a chance?

Did a quick update, and that looks like it fixed it. If there are any another problems in regard to this release I'll open another bug.

lemonsaurus commented 4 years ago

Thanks @bpepple, we really appreciate you taking the time to report these bugs to us!