search

lemonsaurus / django-simple-bulma

Django application to add the Bulma CSS framework and its extensions
MIT License
136 stars 16 forks source link

Move utils imports in to template tag functions #72

Closed edrik closed 3 years ago

edrik commented 3 years ago

Could this be a possible fix for #71 :thinking:

lemonsaurus commented 3 years ago

This is interesting. That might just work.

perlun commented 3 years ago

@lemonsaurus @edrik Sounds really nice. How do we proceed with this, do you want to merge it right away or should I test it locally somehow to see if it resolves my issue?

lemonsaurus commented 3 years ago

If you were able to test it locally, that would be extremely convenient. The hacky, easy way to test it is to just copy paste the code from this pull request straight into your virtual environment install, under /your/venv/folder/lib/python3.x/site-packages/django_simple_bulma/templatetags.

perlun commented 3 years ago

Hacks are perfectly fine at this stage... :grin:

The only problem is that this is rather intermittent. I just tried to run ./manage.py runserver 10 times and couldn't reproduce the issue a single time.

I applied the changes from here (thanks @edrik :pray:), and it worked similarly. 10 times, no exceptions.

So, it at least doesn't seem to make things worse at least. :grin: I can keep the changes for now and will report back if I see it again or not within the next few (working) days.

lemonsaurus commented 3 years ago

@perlun how's it looking? I could probably merge and release this if it seems alright to you now.

lemonsaurus commented 3 years ago

Actually, I'll just merge this and add it to 2.3.1, it's fine.