search

lemonsaurus / django-simple-bulma

Django application to add the Bulma CSS framework and its extensions
MIT License
137 stars 17 forks source link

Versioning #8

Closed gdude2002 closed 4 years ago

gdude2002 commented 5 years ago

While I think it's a good idea to ship Bulma's assets (and that of its extensions) with the PyPi release, it would be nice to be able to specify the specific versions wanted of those for users that do have the option to download those dependencies in their environment.

We'd need to cache them somewhere, of course.

lemonsaurus commented 5 years ago

not sure I see much value in this. why would anyone ever want an older version?

gdude2002 commented 5 years ago

Compatibility was my main thought. Bulma updates but extensions don't, situations like that.

lemonsaurus commented 5 years ago

theoretically we could do this by letting the user specify versions for everything in BULMA_SETTINGS, and if these were specified, getting rid of the .sass and .js files that ship with django-simple-bulma and somehow downloading the right version. No real need to cache a whole bunch of versions as this is likely to only happen once, and a single slow collectstatic seems like an acceptable trade-off.

That said, this would represent a big rewrite, so I'm gonna leave this issue open and if anyone really needs this feature they can leave a note here. I don't know if I see there being much of a demand for it, but if I'm wrong I'm happy to implement it.

lemonsaurus commented 4 years ago

I don't think we need this.