lemonstand / lscloud-theme-meyer

An eCommerce theme built using Angular for LemonStand.
MIT License
2 stars 1 forks source link

Show featured ad tile in products dropdown menu Theme Setting not working #274

Closed jennbrewer closed 6 years ago

jennbrewer commented 6 years ago

Theme Settings checkbox Show featured ad tile in products dropdown menu doesn't do anything.

Shows on the older theme version:

screen shot 2017-10-30 at 10 16 15 am
rudy-sasquatchstudio commented 6 years ago

Just to be clear the expected result should take you to this page - https://meyer.lemonstand.com/products?

jennbrewer commented 6 years ago

Users are able to add the text/link in here themselves but the yellow banner isn't showing in the dropdown navigation when checked. (the photo with the banner is from the old theme)

screen shot 2017-11-01 at 3 21 56 pm
jennbrewer commented 6 years ago

@dhalarewich This yellow banner was showing on the older version - not on the new version. It's in the dropdown menu under Products.

dhalarewich commented 6 years ago

@rudy-sasquatchstudio I believe you had some details on this?

rudy-sasquatchstudio commented 6 years ago

@jennbrewer still not able to reproduce this... @dhalarewich this was with a fresh theme uploaded to our store. Verified several fresh theme uploads including the latest master version from GitHub and was not able to reproduce.

screen shot 2017-11-18 at 11 40 13 pm screen shot 2017-11-18 at 11 40 51 pm

This is all the theme uploads we tried

screen shot 2017-11-18 at 11 45 37 pm
dhalarewich commented 6 years ago

Confirmed that this bug is in Chrome, but not Safari or FireFox. In the previous version of Meyer, this panel was visible in Chrome (see original ticket message) as well.

home___meyer_and_home___meyer
dhalarewich commented 6 years ago

Issue appears to be related to ad blocking extensions hiding this. Likely because of the .featured-ad class name that's used.

To resolve, let's just change that class name in the HTML and all associated CSS styles.

Something innocuous like .featured-panel or .featured-block should work.

Please test against these extensions:

jennbrewer commented 6 years ago

That solved it!