lemontree55 / packetgen

Ruby library to easily generate and capture network packets
MIT License
98 stars 13 forks source link

Add Link-Local Multicast Name Resolution (LLMNR) header. #79

Closed picatz closed 5 years ago

picatz commented 6 years ago

Adding support for LLMNR could be nice to have in the future. 👍

sdaubert commented 5 years ago

@picatz This one will probably be moved to SMB plugin. Any objection?

picatz commented 5 years ago

@sdaubert I think that should work, though I'm pretty sure LLMR might not only deal with SMB traffic?

I'm not sure if it should be its own plugin. However, I do not have any strong objections to moving this to the SMB plugin, especially if it makes it easier on you. 🙇

sdaubert commented 5 years ago

@picatz As i read/understood, LLMNR is a Microsoft protocol, mainly used by windows. This is why i proposed to put it in SMB plugin.

picatz commented 5 years ago

@sdaubert Sounds good to me. 👍