Http handle invalid byte sequence

lemontree55 / packetgen

Ruby library to easily generate and capture network packets

MIT License

98 stars 13 forks source link

Http handle invalid byte sequence #81

Closed picatz closed 6 years ago

picatz commented 6 years ago

HTTP requests and responses are quite a nuisance to deal with. To be quite honest, I'm a little worried about what I might have missed implementing this.

I'm sure I'll stumble upon those problems ( so I can fix them ) later. 😂

Aims to fix https://github.com/sdaubert/packetgen/issues/78

sdaubert commented 6 years ago

OK, nice PR.

Please add a spec to check #81 is fixed. I will merge it next week.

sdaubert commented 6 years ago

@picatz please add a spec to check #78 (and not #81, sorry) is fixed, and i will merge this.

picatz commented 6 years ago

@sdaubert Will happen this week 👍

picatz commented 6 years ago

@sdaubert I got the spec implemented, and while doing so, fixed some issues I found. 😂