lemontree55 / packetgen

Ruby library to easily generate and capture network packets
MIT License
98 stars 13 forks source link

Packet#to_w calculates all calculatable fields before sending. #97

Closed sdaubert closed 6 years ago

sdaubert commented 6 years ago

In current version, user has to explicitly call Packet#calc before sending a packet to send a well-formed packet. This is not done automatically to allow user to send malformed packets on wire.

But, in real life, users want to send well-formed packet more often than bad-formed ones.

In future v3.0.0 of PacketGen, Packet#calc will be automatically called, unless user explicitly forbids it.

picatz commented 6 years ago

@sdaubert Awesome!

I appreciate this being taken care of for me, since it's something I often end up forgetting to do myself.

sdaubert commented 6 years ago

Closed by 132ad40.