search

lempiji / rx

Reactive Extensions for D Programming Language
MIT License
53 stars 8 forks source link

Fixed so subscribeOn actually returns SubscribeOnObservable instead o… #12

Closed ghost91- closed 7 years ago

ghost91- commented 7 years ago

…f ObserveOnObservable

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.01%) to 97.531% when pulling 4bf4d68abcb585f5c07c2de8bec4cd7fbffc7efe on ghost91-:fix_subscribeOn into 73196d7f0f27ef4df1346c1545e0b587a5bccba7 on lempiji:master.

ghost91- commented 7 years ago

It seems there are some more issues with this, the unittest for SubscribeOnObservable also mistakenly uses ObserverOnObservable, but compilation fails if i change it too SubscribeOnObservable, compilation fails: source/rx/scheduler.d(493,36): Error: constructor rx.scheduler.SubscribeOnObservable!(Observable!int, Scheduler).SubscribeOnObservable.this (ref Observable!int observable, ref Scheduler scheduler) is not callable using argument types (SubjectObject!int, LocalScheduler)

I'm planning on taking a closer look at this.

lempiji commented 7 years ago

Thanks for PR. I think I made some mistakes. I will merge this and collect the unittests together.