search

lemunozm / message-io

Fast and easy-to-use event-driven network library.
Apache License 2.0
1.12k stars 75 forks source link

MacOS issue with some unitary tests #6

Closed lemunozm closed 4 years ago

lemunozm commented 4 years ago

Some UTs in src/events.rs related to the timers fails only in macOS builds (see https://github.com/lemunozm/message-io/runs/1339555571?check_suite_focus=true). The issue is non-deterministic.

Unfortunately, I have no Mac to debug it :(

sigmaSd commented 4 years ago

@lemunozm you can try https://github.com/fastai/fastmac

sigmaSd commented 4 years ago

Those 2 tests also fail on linux. But the failure ratio is small, a run fail in 10/20 runs.

lemunozm commented 4 years ago

Thanks! It should be a time issue because in my local Linux those tests never fail. Should be big delays in the Github CI machines. I will check the reason, maybe a higher threshold is the solution.

lemunozm commented 4 years ago

Closed in: https://github.com/lemunozm/message-io/pull/7