Direction::None does not seem to be a useful value; if a user would want to have a value that represents an absent direction, it would probably be more idiomatically expressed as an Option<Direction>.
If you have a good reason for having a None value (which you probably do), then this PR should be rejected. I just personally found it unhelpful and wanted to know about it and make sure.
lemunozm
commented
1 year ago
Direction::Nonedoes not seem to be a useful value; if a user would want to have a value that represents an absent direction, it would probably be more idiomatically expressed as anOption<Direction>.If you have a good reason for having a
Nonevalue (which you probably do), then this PR should be rejected. I just personally found it unhelpful and wanted to know about it and make sure.