search

lemurheavy / coveralls-public

The public issue tracker for coveralls.io
http://coveralls.io
124 stars 7 forks source link

pull request branch link on coveralls pages is wrong #1384

Open ArturKlauser opened 4 years ago

ArturKlauser commented 4 years ago

Every branch link for pull requests points to the wrong github location \<original-repo>/\<fork-branch> rather than \<forked-repo>/\<fork-branch>.

Here \<original-repo> means the repo that was forked from, which is the one tracked by coveralls, and which is the destination of the pull request. \<forked-repo> means the repo that was forked into, i.e. the source repo of the pull request. \<fork-branch> is the branch name within \<forked-repo> that holds the commits that are being put into the pull request.

I see this problem across all repositories tracked by coveralls, e.g. coveralls-python. The only cases where the link works is for trivial pull requests where \<original-repo> and \<fork-repo> are the same, i.e. pulling from a branch within the same repository.

stale[bot] commented 3 years ago

This issue has been automatically marked for closure because it has not had recent activity. It will be closed if no further activity occurs. If your issue is still active please add a comment and we’ll review as soon as we can. Thank you for your contributions.

Minoru commented 3 years ago

This is still an issue. For example, at https://coveralls.io/github/newsboat/newsboat you can see that build 998950978 ostensibly comes from https://github.com/newsboat/newsboat/tree/show-podcast-rename-failure-message whereas in reality it came from https://github.com/kartikeya100/newsboat/tree/show-podcast-rename-failure-message (it's easy enough to check by going to the corresponding PR, https://github.com/newsboat/newsboat/pull/1695, and clicking on the source branch there).

afinetooth commented 3 years ago

@ArturKlauser @Minoru thank you.

FYI, this is a duplicate of this issue: https://github.com/lemurheavy/coveralls-public/issues/1245

We'll try to update both issues when addressed, but please check there as well if seeking an update just in case.

stale[bot] commented 1 year ago

This issue has been automatically marked for closure because it has not had recent activity. It will be closed if no further activity occurs. If your issue is still active please add a comment and we’ll review as soon as we can. Thank you for your contributions.

Minoru commented 1 year ago

This is still an issue: on https://coveralls.io/github/newsboat/newsboat the latest build, 3269039468, ostensibly comes from the branch feature/issue-2220, but that branch is actually in the fork at https://github.com/dennisschagt/newsboat/tree/feature/issue-2220.