search

lemurheavy / coveralls-public

The public issue tracker for coveralls.io
http://coveralls.io
124 stars 7 forks source link

Broken link to travis job - includes extra quotes (") #1395

Closed dennisschagt closed 4 years ago

dennisschagt commented 4 years ago

The links to the relevant Travis Job appears broken. It includes superfluous quotes around the Travis Job ID.

For an example, see https://coveralls.io/builds/28429766 which links to https://travis-ci.org/newsboat/newsboat/jobs/"643862704" instead of https://travis-ci.org/newsboat/newsboat/jobs/643862704

image

Minoru commented 4 years ago

I think I'm the one to blame for this: my coverage submission script puts some command-line arguments into a variable, and then uses that variable as an argument. My intent was to avoid problems with spaces and such if they ever appear in TRAVIS_JOB_ID. However, in reality these escaped double quotes inside the variables are passed verbatim to the command—probably because the shell doesn't try to un-quote things after expanding variables.

In other words, my script unintentionally puts double quotes in JSON. Coveralls simply displays what it's been given by my script.

That's fixed in master now: https://github.com/newsboat/newsboat/commit/2dbe81d6122154d60f7a7c13964b24edb519d03f

This might just be that final little detail that I was missing to fix the reports in Newsboat. I'm waiting for builds to finish right now :)

dennisschagt commented 4 years ago

Nice, thanks for the quick fix!