search

lemurheavy / coveralls-public

The public issue tracker for coveralls.io
http://coveralls.io
124 stars 7 forks source link

Support file encoding #1718

Closed laingsimon closed 1 year ago

laingsimon commented 1 year ago

Is there a means to specify the encoding that the file should be displayed using? Or is there an issue rendering UTF-8 file content?

See this file: https://coveralls.io/builds/60682682/source?filename=CourageScores%2FClientApp%2Fsrc%2Fcomponents%2Fdivision_fixtures%2Fsayg%2FPlayerInput.js#L194

Unicode emoji characters are shown incorrectly, see below. The file is encoded in UTF-8, without a BOM.

Screenshot_2023-06-12-22-16-05-83_40deb401b9ffe8e1df2f1cc5ba480b12

The source file is rendered correctly in GitHub directly Screenshot_2023-06-12-22-19-21-94_40deb401b9ffe8e1df2f1cc5ba480b12

This sounds similar to https://github.com/lemurheavy/coveralls-public/issues/273

afinetooth commented 1 year ago

Hi @laingsimon. Thanks for reporting this, with an example. I've created an internal ticket and will follow-up when its updated.

nebolsin commented 1 year ago

@laingsimon thank you for bringing this to our attention, this should be fixed now. Please, check it out and feel free to re-open the issue if anything doesn't look right still.

laingsimon commented 1 year ago

Thanks for your support and quick response, all working as expected.

afinetooth commented 1 year ago

Thanks, @laingsimon and @nebolsin!