search

lemurheavy / coveralls-public

The public issue tracker for coveralls.io
http://coveralls.io
124 stars 7 forks source link

Option to state which SHA to compare to #630

Open eteq opened 9 years ago

eteq commented 9 years ago

Right now it appears (at least with Travis) that coveralls always does comparisons against master when deciding how much coverage increases/decreases. This is problematic on an active project where the master branch changes a lot - if anyone has a PR that's not coming off the latest master, the coverage stats mostly reflect changes in master rather than changes in the PR.

The straightforward solution would seem to be to enhance the API to allow passing in the SHA (or coveralls build number) of the coverage report to base the comparison on. Better yet (for my project's needs) would be to trace a PR back to where it branched from master and use that as the comparison point... But that's got more assumptions built in, so making it part of the coveralls API seems like an easier thing to try.

yebyen commented 6 years ago

Bump... Seems like a great idea.

We spend most of our time merging feature branches into the dev branch, but some of the time we are culling commits from the dev branch into master for release engineering.

Would be awesome if we didn't have to get an admin user of Coveralls to adjust our project every time we need to make this context switch.