search

lemurheavy / coveralls-public

The public issue tracker for coveralls.io
http://coveralls.io
124 stars 7 forks source link

Github status update is going to the wrong commit on a pull request #736

Closed nubs closed 4 years ago

nubs commented 8 years ago

I'm using Travis CI on a new PHP project and trying to get things set up so that the coveralls report updates the merge status of pull requests. The initial pull request however isn't working as expected. Travis CI is updating its status just fine and is also firing off the report to coveralls, where I can see the coverage report being generated. However, the GitHub commit in the PR is not being updated with the status.

Digging into it further, Coveralls is making a request to update the status of a commit, but it seems to be updating the status of the wrong commit: it's updating the merge commit associated to the pull request rather than the commit of the branch the PR is based on. I've done this before with no problem, and I don't see anywhere in the configuration where this could be happening. What could be causing this?

The PR is flocasts/scaleengine-api-client#2 and you can see the 2 commits here. Note that the first commit has Travis CI and Scrutinizer CI statuses on it (but no coveralls status), and the second commit has the coveralls status.

I'm not sure what's to blame. I have other existing projects that are working as expected. I also opened up an issue at satooshi/php-coveralls#190, but the problem doesn't seem to lie there.

stale[bot] commented 4 years ago

This issue has been automatically marked for closure because it has not had recent activity. It will be closed if no further activity occurs. If your issue is still active please add a comment and we’ll review as soon as we can. Thank you for your contributions.