lenLRX
commented
6 years ago https://github.com/lenLRX/Dota2_DPPO_bots/blob/last_hit/cppSimulator/src/Hero.cpp#L288 this just returns a heading (missing length of move), not sure if intended b/c I didn't dig deep enough to see how it's used
yes it is only heading of hero, and it is used by Python side program as "teacher".
https://github.com/lenLRX/Dota2_DPPO_bots/blob/last_hit/cppSimulator/src/Sprite.cpp#L138 More clearer to use get_ProjectileSpeed() to show it's a (protected) memeber
https://github.com/lenLRX/Dota2_DPPO_bots/blob/last_hit/cppSimulator/src/Sprite.cpp#L127 Not a big thing, but consistency, use "hypot()" like you did on line 52
https://github.com/lenLRX/Dota2_DPPO_bots/blob/last_hit/cppSimulator/src/Sprite.cpp#L76 "damaged" (spelling)
https://github.com/lenLRX/Dota2_DPPO_bots/blob/last_hit/cppSimulator/src/Hero.cpp#L288 this just returns a heading (missing length of move), not sure if intended b/c I didn't dig deep enough to see how it's used
https://github.com/lenLRX/Dota2_DPPO_bots/blob/last_hit/cppSimulator/src/Hero.cpp#L145-L146 Why 1000? Why not use MovementSpeed?
https://github.com/lenLRX/Dota2_DPPO_bots/blob/last_hit/cppSimulator/src/Creep.cpp#L34 Ranged Creep have "Piercing" attacks... so if you are representing their damage it's actually closer to 35 dmg against other creep, but 12 against Heroes. See Here: https://dota2.gamepedia.com/Attack_damage#Attack_damage_types
https://github.com/lenLRX/Dota2_DPPO_bots/blob/last_hit/cppSimulator/src/Config.cpp#L4 Shouldn't it be 7000, not 700?
I really want to add your simulation capability with my framework as there is no way I can see of getting enough training or self-play data with even a headless or custom-game implementation of Dota.