Business service and business controller refactoring, exception handling

lenagainulina / lost-in-berlin

A B2C web and mobile app

0 stars 1 forks source link

Business service and business controller refactoring, exception handling #33

Closed lenagainulina closed 5 years ago

lenagainulina commented 6 years ago

Fixes #32

refactored business controller so that it knows less
implemented all business logic in business service
added unit tests for controller and integration tests for the service (please see comments)
added more exceptions and exception handler.

sergeylukichev commented 6 years ago

Looks good so far. I will check what is wrong with tests.

sergeylukichev commented 5 years ago

It is a bit hard to help since the branch is not compilable, for instance, OrderController importsimport de.berlin.lostberlin.model.Order;, however, such file does not exist anymore, you seem to movied it to another packages. Because of this, I assume, I cannot run the tests with lombok.

Can you make sure that the branch can be compiled and only jpa-related problem is there so I could have a look.