lenarother / django-critical-css

This package helps to optimize the critical rendering path for django websites
MIT License
3 stars 1 forks source link

Critical CSS creates a new page entry for every query string #4

Closed Schascha closed 4 years ago

Schascha commented 4 years ago

Hi Magda, I hope you're doing well. Maybe there will be a possibility to reduce database entries. Critical CSS creates a new page entry for every query string:

Bildschirmfoto 2020-08-25 um 11 16 40

In this above example it will produce nearly 1000 entries. Do you think it will be better to reduce the entries?

Thanks, Sascha

lenarother commented 4 years ago

Hey @Schascha ,

I am very glad to hear from you, I hope you have a great start after your holiday. I assume that you've been greeted by a lot of critical objects.

As to your request: I think there is a possibility that the query string is important for calculating the critical css - which is why I don't want to remove it completely. I've added a switch (setting) that allows you to ignore it.

In order to benefit from the change you must:

Cheers, Magda