lenchv / hive-driver

Driver for connection to Apache Hive via Thrift API
MIT License
40 stars 9 forks source link

Add setMaxRows to IOperation #42

Closed drzippie closed 2 years ago

drzippie commented 2 years ago

Need to use method operation.setMaxRows( number )

Issue: #41

drzippie commented 2 years ago

The test "HiveClient.connect" > should use tcp connection by default: Fails in the current master branch:

     TypeError [ERR_MISSING_ARGS]: The "options" or "port" or "path" argument must be specified

I've fixed the test setting port and path to validate that client.connectionProvider is a instance of TcpConnection

codecov-commenter commented 2 years ago

Codecov Report

Merging #42 (0cc7702) into master (27acece) will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   93.32%   93.30%   -0.03%     
==========================================
  Files          58       58              
  Lines        1049     1045       -4     
  Branches      107      107              
==========================================
- Hits          979      975       -4     
- Misses         38       39       +1     
+ Partials       32       31       -1     
Impacted Files Coverage Δ
lib/connection/auth/helpers/KerberosStep.ts 71.73% <0.00%> (-0.61%) :arrow_down:
lib/result/JsonResult.ts 80.64% <0.00%> (-0.31%) :arrow_down:
lib/utils/WaitUntilReady.ts 100.00% <0.00%> (ø)
lib/connection/connections/TcpConnection.ts 76.92% <0.00%> (ø)
...onnection/auth/helpers/MongoKerberosAuthProcess.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27acece...0cc7702. Read the comment docs.

lenchv commented 2 years ago

Hi @drzippie ! Looks fine, the wierd thing that test failed, but seems to be correct. I'll merge and release changes soon. Cheers =)

drzippie commented 2 years ago

@lenchv ... sorry, seems to be needed execute a npm run build, and commit dist/contracts/IOperation.d.ts

I had erroneously assumed that dist was generated automatically

lenchv commented 2 years ago

whoops, I also forget about this. I'll build and release it, no worries