lendup / fs2-blobstore

Minimal, idiomatic, stream-based Scala interface for key/value store implementations
Apache License 2.0
92 stars 26 forks source link

run tests with docker compose #20

Closed rolandomanrique closed 6 years ago

rolandomanrique commented 6 years ago

Enables running S3 and SFTP integration in travis builds by running docker containers for minio (as suggested in #18) and SFTP server. Tests are set up by default to run through docker compose.

codecov-io commented 6 years ago

Codecov Report

Merging #20 into master will increase coverage by 18.91%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #20       +/-   ##
===========================================
+ Coverage   27.47%   46.39%   +18.91%     
===========================================
  Files           7        7               
  Lines         222      222               
  Branches       10       10               
===========================================
+ Hits           61      103       +42     
+ Misses        161      119       -42
Impacted Files Coverage Δ
core/src/main/scala/blobstore/package.scala 100% <0%> (+42.85%) :arrow_up:
s3/src/main/scala/blobstore/s3/S3Store.scala 79.59% <0%> (+79.59%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ffbffc...0c6ef31. Read the comment docs.

rolandomanrique commented 6 years ago

Merging this to get S3 coverage in, need more work to figure out why sftp tests are failing in travis.